Opened 5 years ago
Closed 5 years ago
#22568 closed enhancement (fixed)
Polyhedron_ZZ should inherit from Polyhedron_QQ, not Polyhedron_base
Reported by: | mkoeppe | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-7.6 |
Component: | geometry | Keywords: | days84 |
Cc: | jipilab, vdelecroix | Merged in: | |
Authors: | Matthias Koeppe | Reviewers: | Jean-Philippe Labbé |
Report Upstream: | N/A | Work issues: | |
Branch: | 67eb1d7 (Commits, GitHub, GitLab) | Commit: | 67eb1d7e74c7eaa0bf640550cdf60160a7a893ef |
Dependencies: | Stopgaps: |
Description (last modified by )
This is so we can define methods that require rational data in Polyhedron_QQ
, and they will become available to polyhedra defined with integral data.
Change History (10)
comment:1 Changed 5 years ago by
- Branch set to u/mkoeppe/polyhedron_zz_should_inherit_from_polyhedron_qq__not_polyhedron_base
comment:2 Changed 5 years ago by
- Commit set to 67eb1d7e74c7eaa0bf640550cdf60160a7a893ef
- Status changed from new to needs_review
comment:3 Changed 5 years ago by
- Description modified (diff)
comment:4 Changed 5 years ago by
- Reviewers set to Jean-Philippe Labbé
All tests pass on the base classes files and the library of polytopes.
LGTM, once the bot gives the green light, I'll change it to positive review.
comment:5 Changed 5 years ago by
- Keywords days84 added
comment:6 Changed 5 years ago by
Any idea why it does not build on the bot?
comment:7 Changed 5 years ago by
As far as I can see, the build failed because of an unrelated error (upstream package lrslib-062+autotools-2017-03-03.tar.gz not present on mirrors -- this seems to have been fixed since)
comment:8 Changed 5 years ago by
- Status changed from needs_review to positive_review
The last bot test passed on 7.6.rc0. This looks good to me.
comment:9 Changed 5 years ago by
Thank you!
comment:10 Changed 5 years ago by
- Branch changed from u/mkoeppe/polyhedron_zz_should_inherit_from_polyhedron_qq__not_polyhedron_base to 67eb1d7e74c7eaa0bf640550cdf60160a7a893ef
- Resolution set to fixed
- Status changed from positive_review to closed
New commits:
Change Polyhedron_ZZ to inherit from Polyhedron_QQ, not Polyhedron_base